Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(routing): remove react-router-dom dependency #3862

Closed

Conversation

devin-ai-integration[bot]
Copy link

Remove react-router-dom dependency

Summary

  • Replaced react-router-dom with custom routing implementation
  • Updated all imports to use custom router components
  • Removed react-router-dom from package dependencies
  • Updated tests to use custom router components
  • Upgraded history package from v4 to v5

Verification

  • ✅ yarn lint:js passed
  • ✅ yarn lint:ts passed
  • ✅ yarn lint:css passed
  • ⚠️ Test environment issues reported to maintainers

Evidence of react-router-dom removal

Package.json changes show react-router-dom was removed and history was upgraded to v5:

- "react-router-dom": "^5.3.4",
+ "history": "^5.3.0",

Link to Devin run

https://app.devin.ai/sessions/08d21c999f214b2e9982907723bf4bf6

@devin-ai-integration devin-ai-integration bot requested review from a team as code owners January 23, 2025 02:06
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Author

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants