feat(docgen-sidebar): add polling to tags loading in dogen sidebar #3858
+111
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustam-e
commented
Jan 24, 2025
tjuanitas
reviewed
Jan 28, 2025
Co-authored-by: Trevor <[email protected]>
tjuanitas
approved these changes
Jan 28, 2025
JChan106
reviewed
Jan 30, 2025
| setHasError(false); | ||
| } else { | ||
| const loadTags = useCallback( | ||
| async (attempts = 10) => { |
There was a problem hiding this comment.
Is there a reason we chose to go with 10 attempts? I feel like most of the time we do 3 - 5 attempts for retries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
if the template has been updated and tags have not been processed - user would see error state requesting them to click a refresh button
after:
components tries re-fetching up to 10 times and only then shows the error state