feat(content-uploader): add onSelection callback (#3839) #3841
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
| directory={isFolderUpload ? '' : undefined} | ||
| multiple={isMultiple} | ||
| onChange={onChange} | ||
| onChange={(event: React.ChangeEvent<HTMLInputElement>) => { |
There was a problem hiding this comment.
That comes handy when trying to upload files and their size exceeded 50mb (5010001000 as I figured Box doesn't like 5010241024 too much ;)).
Currnetly I handled it by observing classList string and reacting to the change after the onBeforeUpload fired and contentExplorer changed it's button classes etc.
| if (onSelection && files) { | ||
| const shouldContinue = onSelection(files); | ||
| if (!shouldContinue) { | ||
| return; |
There was a problem hiding this comment.
Is there a way to clear out the file list other than doing files = ''?
I know there's clearCache for remote but it'd be helpful to be able to reset the form other than clicking cancel.
I've found some information scattered around the web about this UI element but the documentation doesn't mention this event and even more intruiguing is that it doesn't really work as I would expect it to. I should be able to validate files (like exceeded size, fileType) before even allowing user to click "upload" button. That's not the case and I've already got davin to write some code: box/box-ui-elements#3841
| be.versionDeleted = {name} v{version_number}মুছে দিয়েছে | ||
| # Message displayed in the activity feed to represent the range of versions actioned by multiple users. {numberOfCollaborators} is a number. {actionMessage} is the action. {versions} is a range of versions. | ||
| be.versionMultipleUsersCollapsed = {numberOfCollaborators} collaborators {actionMessage} v{versions} | ||
| be.versionMultipleUsersCollapsed = {numberOfCollaborators} কোলাবোরেটর {actionMessage} v{versions} |
There was a problem hiding this comment.
is it trying to handle it's own translations?
There was a problem hiding this comment.
Do we need to address that or is the PR good to go?
|
Closing due to inactivity. |
I don't think so. |
Description
This PR adds an
onSelectioncallback to the ContentUploader component to allow developers to control file selection before upload begins. This implements the suggestion from issue #3839.Changes
onSelectionprop to ContentUploader componentUsage
Testing
Link to Devin run: https://app.devin.ai/sessions/acbecd8da4154ad8aba8d8d81d7bd661