Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Drop support node version below 12 and fix vulnerabilities #802

Merged
merged 4 commits into from
Feb 22, 2023
Merged

feat!: Drop support node version below 12 and fix vulnerabilities #802

merged 4 commits into from
Feb 22, 2023

Conversation

congminh1254
Copy link
Member

@congminh1254 congminh1254 commented Feb 14, 2023 •
edited
Loading

In this PR:

  • Drop support for Node version below 12.
  • Fix package vulnerabilities, all left behind is only using in dev environment.
  • Update CI.
  • Verified working with FIPS.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4175313509

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.279%
Totals Coverage Status
Change from base Build 4069288060: 0.0%
Covered Lines: 2802
Relevant Lines: 2876
💛 - Coveralls

@congminh1254 congminh1254 changed the base branch from main to version_3.0 February 15, 2023 13:34
arjankowski
arjankowski reviewed Feb 17, 2023
View reviewed changes
UPGRADE.md Outdated Show resolved Hide resolved
arjankowski
arjankowski approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@arjankowski arjankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@congminh1254 congminh1254 merged commit 5b1d4e9 into version_3.0 Feb 22, 2023
@congminh1254 congminh1254 deleted the sdk-2888-drop-support-old-node-version branch February 22, 2023 16:33
@thoean
Copy link

thoean commented Mar 6, 2023

Excellent change. When will this be available in a new release?

@congminh1254 congminh1254 mentioned this pull request May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjankowski arjankowski arjankowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

high severity in jsonwebtoken <=8.5.1
4 participants
@congminh1254 @coveralls @thoean @arjankowski