Skip to content

Deeply freeze Config except Buffers and Readable streams #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Conversation

mhagmajer
Copy link
Contributor

Following up on #146 which got reverted, I'm using the same approach but while also avoiding freezing Readable streams. Added unit tests from the original PR and also another one to cover the Readable stream case.

I created an external Node application that was using SDK with this change applied to perform several common tasks:

  • fetching a folder
  • getting retention policy assignments
  • getting files under retention for an assignment
  • getting file versions under retention for an assignment
  • deleting a file
  • uploading a file (here's where Readable stream was used)

Closes #142.

@PJSimon PJSimon merged commit 60f892a into main Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config object not deeply immutable
2 participants