test: Skip the PharFactory testson PHP 8.1 #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when merging a couple of PRs the CI is having a meltdown. This is an attempt to reduce the load.
The Phar Factory tests fail on PHP 8.1 and I am not sure why. However I will probably bump to PHP 8.2 the minimum PHP version soon anyway and the actual used code is a lot more robust hence this should not be a problem.
theofidry
added a commit
to theofidry/box
that referenced
this pull request
Oct 6, 2023
Revert box-project#1024: the actual issue is about whether the phar.readonly is on or off rather than the PHP version.
theofidry
added a commit
that referenced
this pull request
Oct 6, 2023
Revert #1024: the actual issue is about whether the phar.readonly is on or off rather than the PHP version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Phar Factory tests fail on PHP 8.1 and I am not sure why. However I will probably bump to PHP 8.2 the minimum PHP version soon anyway and the actual used code is a lot more robust hence this should not be a problem.