-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add Node.js 18, 20 & 22 #2630
Conversation
MacOS-latest can run Node versions 6 - 14 anymore. Pin them to MacOS-13 to keep the actions running
I'm afraid someone would need to make windows tests pass first again. Bower is in maintenance mode |
Might take a second look at the Windows actions later. It is probably something about how actions are run in Windows OS in general in Github, as simply using an older Windows OS did not change the outcome. |
I debugged this a bit in another branch. Didn't seem to find any solutions for the Windows issues. The situation in current master without changes seems to be:
In short, of the three operating systems only one is completely passing. The situation after this PR is:
In short, of the three operating systems two are completely passing. I tried to see if these Windows tests had actually even passed earlier in the main repo, but could not find run history for it. Whatever the situation was before, this PR does seem to do fix current CI problems and make none of the problems worse. I'll leave this open for now @sheerun . Up to you if you'll want to merge this one or wait should someone else take a look at the Windows issue. If you ask me, the pipeline is less broken after this PR 😅 |
I guess you are right, could you just mark failing environments as skipped or optional? Thank you for working on it |
Thats a good idea. I'll mark failing ones to pipelines when I have a moment to look at this again. |
12db87d
to
207f656
Compare
All Windows pipelines currently fail for some integration tests. It seems to be a question of running actual git commands inside a Windows based Github action runner. Reverting it to older Windows runner wont help.
207f656
to
81d31fd
Compare
Alright, the PR now marks |
thank you! |
All currently supported Node versions were missing from CI version matrix. Add them.
This lead to realization that GIthub Action runner for MacOS-latest does not support Node.js versions older than 16 any more. To keep the old versions supported, pin them to older version MacOS-13, which is the latest version with correct architecture to run those versions.
All Windows actions seem to fail for unrelated reason. They fail on master of Bower as well, so it is not a question changes in this PR.