Fix update command not installing missing packages #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentGoderre
changed the title
|
@sheerun this addresses the immediate problem. If you agree with the change, can we merge and bump? I will add the rest of the test after the bump. |
LaurentGoderre
changed the title
|
@sheerun this is ready to go if you are ok with it. It has all the base test too |
|
Thank you, embarrassing mistake :) It'll try to release this fix as soon as possible. |
sheerun
added a commit
that referenced
this pull request
Sep 16, 2014
Fix update command not installing missing packages
|
@sheerun this kind of stuff is quite frequent I find. That's why we write tests, to protect us from ourselves ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.