Need CRUD and additional endpoints implementation #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehmetkuzu
previously requested changes
Oct 30, 2023
Thank you for the review, I'll fix it |
mehmetkuzu
approved these changes
Oct 30, 2023
|
|
||
| def create_need(need: Need) -> str: | ||
| # Manual validation for required fields during creation | ||
| if not all([need._id, need.created_by, need.urgency, |
There was a problem hiding this comment.
Actually this does not effect. As it is None. So the current code is ok with that.
|
|
||
| def get_needs(need_id:str = None) -> list[dict]: | ||
| projection = { | ||
| "$toString": "$_id", |
There was a problem hiding this comment.
This gives error. You can change it with
"_id": {"$toString": "$_id"},
| # needs_data = needs_collection.find() | ||
|
|
||
| # return [{ | ||
| # "_id": str(need_data["_id"]), |
There was a problem hiding this comment.
Again
"_id": {"$toString": "$_id"},
| @@ -4,7 +4,8 @@ | |||
| from Services import resource_service | |||
| from Services.build_API_returns import * | |||
|
|
|||
| from Controllers import resource_controller, user_controller, uprofile_optinfo_controller, uprofile_languages_controller | |||
|
|
|||
| from Controllers import resource_controller, user_controller, uprofile_optinfo_controller, uprofile_languages_controller, user_profile_controller, need_controller | |||
There was a problem hiding this comment.
Would you remove the user_profile_controller
We changed the name but possibly mixed
azizamankenova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need related endpoints are implemented