Mo/feature/profile page UI #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Disaster-Response-Platform/mobile/DisasterResponsePlatform/app/build.gradle
egecans
reviewed
Oct 23, 2023
| @@ -0,0 +1,6 @@ | |||
| package com.example.disasterresponseplatform.models | |||
There was a problem hiding this comment.
Could you please move this package under the data -> models -> user types ( you can create this package ) to continue our package design
egecans
reviewed
Oct 23, 2023
|
|
||
| var counter = 0; | ||
| for (socialMedia in user.socialMedia) { | ||
| val newView: View = LayoutInflater.from(requireContext()).inflate(R.layout.profile_item, null) |
There was a problem hiding this comment.
You can use binding in here like:
val navViewBinding: ProfileItemBinding = ProfileItemBinding.inflate(LayoutInflater.from(requireContext()))
After that you can easily access binding objects like:
navViewBinding.profileItemText.text instead of newView.findViewById(R.id.profile_item_text).text
egecans
approved these changes
Oct 23, 2023
This was referenced Oct 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented profile page UI. There are many fields that can possibly be present in the UI. To see different cases, I hardcoded 3 temporary users. When the profile page opens up, a random user is picked. So close and open the page a few times to see 3 different users.
I also added an edit button. Depending on which person this profile has (me or someone else) this button can be hidden. It's the same for the call button as well.
I entered my phone number, so if you press the call button you will call me.
Thiss PR solves issues #335 and #373