Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple map design #364

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Simple map design #364

merged 2 commits into from
Oct 22, 2023

Conversation

Sahin-Albayram
Copy link
Contributor

ChangeLog:

  • MapLayout Created,
  • Navigation bar created as a component
  • Simple map designed
  • New Map component created for map page

@mervegrbz mervegrbz linked an issue Oct 22, 2023 that may be closed by this pull request
Frontend - Simple map page initialization #309
Closed
@Sahin-Albayram Sahin-Albayram linked an issue Oct 22, 2023 that may be closed by this pull request
Frontend - Organizing MainLayout and Creating MapLayout #360
Closed
mervegrbz
mervegrbz reviewed Oct 22, 2023
View reviewed changes
Copy link
Contributor

@mervegrbz mervegrbz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add colors you are using as variables in variables.css file. So that we can use the same colors

Disaster-Response-Platform/frontend/components/Map/MapFilterMenu.module.scss Outdated Show resolved Hide resolved
Disaster-Response-Platform/frontend/components/Map/MapFilterMenu.js Outdated Show resolved Hide resolved
Disaster-Response-Platform/frontend/components/Map/MapFilterMenu.module.scss Outdated Show resolved Hide resolved
Disaster-Response-Platform/frontend/pages/map/index.js Show resolved Hide resolved
mervegrbz
mervegrbz approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@mervegrbz mervegrbz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Sahin-Albayram Sahin-Albayram merged commit e61acf3 into main Oct 22, 2023
@Sahin-Albayram Sahin-Albayram deleted the FE/design/simple-map branch October 22, 2023 16:26
@Sahin-Albayram Sahin-Albayram self-assigned this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mervegrbz mervegrbz mervegrbz approved these changes

Assignees

@Sahin-Albayram Sahin-Albayram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontend - Organizing MainLayout and Creating MapLayout Frontend - Simple map page initialization
2 participants
@Sahin-Albayram @mervegrbz