Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De/feature/add docker compose #322

Merged
merged 3 commits into from
Oct 17, 2023
Merged

De/feature/add docker compose #322

merged 3 commits into from
Oct 17, 2023

Conversation

mervegrbz
Copy link
Contributor

Changelog:

  • Add docker-compose
  • add dockerfiles for backend and frontend

@mervegrbz mervegrbz requested a review from bgmrsln October 17, 2023 10:55
@mervegrbz
Copy link
Contributor Author

@bgmrsln Can you check the dockerfile in backend? I just copied it from previous semester 👀

bgmrsln
bgmrsln reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@bgmrsln bgmrsln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we use npm instead of yarn?

@mervegrbz
Copy link
Contributor Author

why we use npm instead of yarn?

at first step, I thought I could be good to use simple one since many of us started to learn :)

@bgmrsln
Copy link
Contributor

bgmrsln commented Oct 17, 2023

Looks good to me! <3

@bgmrsln bgmrsln closed this Oct 17, 2023
@bgmrsln bgmrsln reopened this Oct 17, 2023
@mervegrbz mervegrbz requested a review from bgmrsln October 17, 2023 11:34
bgmrsln
bgmrsln approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@bgmrsln bgmrsln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me <3

@bgmrsln bgmrsln merged commit b546a2e into main Oct 17, 2023
@mervegrbz mervegrbz deleted the DE/feature/add-docker-compose branch October 17, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgmrsln bgmrsln bgmrsln approved these changes

Assignees

@bgmrsln bgmrsln

@mervegrbz mervegrbz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mervegrbz @bgmrsln