Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

practice-app/bug-fix/user-#87 User API bugs are fixed #89

Merged
merged 1 commit into from
May 10, 2022

Conversation

mehmetemreakbulut
Copy link
Contributor

After implementing essential functionalities of User API, some bugs has arisen.

Bugs that is fixed:

  • No error message as response to the creation of a user with username that already exists.
  • Can't reach data when POST request is sended as a row JSON from Postman.
  • Allows password field to be empty
  • Don't check whether email is taken or not
  • No error message if user creation is failed
  • Email is not mandatory currently, however email is required for external API.
  • No email validation

Also endpoints are changed.

  • New endpoint for listing all users and creating a user: user/api.
  • New endpoint for showing a spesific user detail with given username: user/api/<str: username>.
  • Structure of APIs is same as mentioned in issue Practice App: Implementing API for User #81.

After review, we can merge to master.

@mehmetemreakbulut mehmetemreakbulut added Type: Bug Something isn't working Prio: High Importance of Issue: High Status: Need Review Issue work is done, waiting to be reviewed labels May 10, 2022
@mehmetemreakbulut mehmetemreakbulut self-assigned this May 10, 2022
@kardelendemiral kardelendemiral merged commit ede264b into master May 10, 2022
@mehmetemreakbulut mehmetemreakbulut linked an issue May 10, 2022 that may be closed by this pull request
9 tasks
@mehmetemreakbulut mehmetemreakbulut changed the title User API bugs are fixed practice-app/bug-fix/user-#87 User API bugs are fixed May 11, 2022
@palahb palahb deleted the practice-app/bug-fix/user-#87 branch October 22, 2022 22:23
@palahb palahb added Status: Accepted Issue is reviewed, accepted and removed Status: Need Review Issue work is done, waiting to be reviewed labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: High Importance of Issue: High Status: Accepted Issue is reviewed, accepted Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Practice App: Implementing API for User - Bug Fix and Enhancements
3 participants