[Backend] General fixes #338 #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehmetemreakbulut
added
Type: Bug
|
oguzhandemirelx
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Nice work @mehmetemreakbulut. Your improvements which is mentioned in Issue 338 are okay. Uploading images to S3 works correctly. It makes sense to add new database tables. On the Comment object, CRUD operations function properly. I am merging this PR.
canberkboun9
reviewed
Dec 1, 2022
| doctor_data = {} | ||
| full_name = f"{request.data['firstname']} {request.data['lastname']}" | ||
| doctor_data['full_name'] = full_name | ||
| doctor_data['specialization']= Category.objects.get(name=request.data['branch']).id | ||
| doctor_data['user'] = account.id | ||
| doctor_serializer = DoctorSerializer(data=doctor_data) | ||
| if doctor_serializer.is_valid(): | ||
| doctor_serializer.save() | ||
| doctor = doctor_serializer.save() | ||
| print(request.FILES) |
There was a problem hiding this comment.
should this print statement deleted?
canberkboun9
reviewed
Dec 1, 2022
| print(request.FILES) | ||
| if len(request.FILES) > 0: | ||
| for filename, file in request.FILES.items(): | ||
| print(filename) |
palahb
added
Status: Need Review
mehmetemreakbulut
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fundamental structure of APIs is built, however, we have to add new fields or configs to align with frontend and mobile. Some fixes we determined listed below.
Tasks Done:
Reviewer:
@oguzhandemirelx
Notes:
article/{article.id}/{image.id}.jpgpost/{post.id}/{image.id}.jpgcomment/{comment.id}/{image.id}.jpgdocument/{account.id}/{filename}{extension}longitude:floatandlatitude:floatpaginatorwe have developed.Issue: