Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] Refactoring After Milestone 2 #434

Closed
3 tasks done
mehmetemreakbulut opened this issue Dec 16, 2022 · 3 comments · Fixed by #435
Closed
3 tasks done

[Backend] Refactoring After Milestone 2 #434

mehmetemreakbulut opened this issue Dec 16, 2022 · 3 comments · Fixed by #435
Assignees
@mehmetemreakbulut
Labels
Code refactor Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Team: Backend Backend based work - for backend team

Comments

@mehmetemreakbulut
Copy link
Contributor

mehmetemreakbulut commented Dec 16, 2022 •
edited
Loading

Description:

For Milestone 2 we have implemented general functionalities of the application. However, there is still missing part in backend in in term of convention. Also, I will make the codebase more clear and understandable.

Todo's:

  • Refactoring of Endpoints
  • Refactoring of Models
  • Refactoring of Serializers

Reviewer: @canberkboun9

Task Deadline: 16.12.2022 24:00
@mehmetemreakbulut mehmetemreakbulut added Prio: Medium Importance of Issue: Medium Type: Enhancement New features via code and/or design. Status: In Progress Issue is worked on, currently Team: Backend Backend based work - for backend team labels Dec 16, 2022
@mehmetemreakbulut mehmetemreakbulut self-assigned this Dec 16, 2022
@mehmetemreakbulut
Copy link
Contributor Author

  • I have reviewed the code and found some parts that needed to refactor in Forum and Articles module
  • Not functional changes but need refactoring of course!

@mehmetemreakbulut mehmetemreakbulut mentioned this issue Dec 16, 2022
Merged
2 tasks
@mehmetemreakbulut
Copy link
Contributor Author

  • Forum and Articles endpoints refactored.
  • I have opened PR.
  • Need review @canberkboun9 !

@canberkboun9 canberkboun9 added Code refactor and removed Type: Enhancement New features via code and/or design. labels Dec 16, 2022
canberkboun9 added a commit that referenced this issue Dec 16, 2022
@canberkboun9
Merge pull request #435 from bounswe/backend/feature/refactoring-#434
c97f17c 
Backend/feature/refactoring #434
@canberkboun9 canberkboun9 linked a pull request Dec 16, 2022 that will close this issue
[Backend] General Refactoring #435
Merged
2 tasks
@canberkboun9
Copy link
Contributor

I reviewed and merged the PR. We can close the issue now. Nice work!

@mehmetemreakbulut mehmetemreakbulut added Status: Accepted Issue is reviewed, accepted and removed Status: In Progress Issue is worked on, currently labels Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetemreakbulut mehmetemreakbulut

Labels
Code refactor Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Team: Backend Backend based work - for backend team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Backend] General Refactoring bounswe/bounswe2022group5
2 participants
@canberkboun9 @mehmetemreakbulut