Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for personal repos #3464

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

Vingian
Copy link
Contributor

@Vingian Vingian commented Aug 11, 2024

Description

So if for any reason components, dependencies or programs are not being updated... users will be able to fork and update themselves easily(like PERSONAL_COMPONENTS=https://github.com/Vingian/Bottles_components/raw/main). The possibility of using a local repository is maintained by simply specifying file://(like PERSONAL_COMPONENTS=file:///home/Vingian/Bottles_components).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@mirkobrombin
Copy link
Member

Note for me: maintainer's docs needs to be updated once this is merged.

@mirkobrombin mirkobrombin changed the title Personal repositories... feat: support for personal repos Aug 13, 2024
Copy link
Contributor

Pylint result on modfied files:
************* Module bottles.backend.managers.repository
bottles/backend/managers/repository.py:62:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
bottles/backend/managers/repository.py:84:8: C0206: Consider iterating with .items() (consider-using-dict-items)
bottles/backend/managers/repository.py:93:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
bottles/backend/managers/repository.py:94:19: I1101: Module 'pycurl' has no 'E_OK' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/managers/repository.py:97:19: I1101: Module 'pycurl' has no 'E_ABORTED_BY_CALLBACK' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/managers/repository.py:115:24: I1101: Module 'pycurl' has no 'Curl' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/managers/repository.py:125:27: I1101: Module 'pycurl' has no 'error' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/managers/repository.py:34:0: R0903: Too few public methods (1/2) (too-few-public-methods)

@mirkobrombin mirkobrombin merged commit c796752 into bottlesdevs:main Aug 13, 2024
5 checks passed
@Vingian Vingian deleted the patch-1 branch September 6, 2024 03:57
@Vingian Vingian restored the patch-1 branch September 6, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants