Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Can't run bottles with spaces in name through bottle picker #3287

Closed
LittleAmpton opened this issue Feb 21, 2024 · 1 comment · Fixed by #3451
Closed

[Bug]: Can't run bottles with spaces in name through bottle picker #3287

LittleAmpton opened this issue Feb 21, 2024 · 1 comment · Fixed by #3451

Comments

@LittleAmpton
Copy link
Contributor

LittleAmpton commented Feb 21, 2024

Describe the bug

If in the "bottle picker" dialog (say, from the right-click menu) you pick a bottle with a space in its name, a hyphen will be added to the name, and it won't be run.
In the command line, if I try to run the program in, say, bottle named "Normal Games", following error will appear: Bottle Normal-Games not found
Similarly, trying to run an imported bottle named krzysiek says that a bottle named Imported_krzysiek is not found.
Trying to run a one-word bottle works as expected.

I'm not a GTK programmer so I can't say for sure, but the issue seems to be located in the file bottles/frontend/windows/bottlepicker.py, line 74:

["bottles-cli", "run", "-b", row.bottle, "-e", self.arg_exe]

I'm assuming row is of type BottleEntry.
bottle member of type BottleEntry is defined as follows:

self.bottle = config.Path

Thus, the bottle's path is passed to bottles-cli, which expect the bottle's name.

To Reproduce

  1. Run the command flatpak run --command=bottles com.usebottles.bottles [executable name]
  2. Pick a bottle with a space in its name.
  3. Observe how it doesn't run.

Package

Flatpak from Flathub

Distribution

Void Linux

Debugging Information

Official Package: true
Version: '51.11'
DE/WM: plasma
Display:
    X.org: true
    X.org (port): :0
    Wayland: false
Graphics:
    vendors:
        nvidia: &id002
            vendor: nvidia
            envs:
                __NV_PRIME_RENDER_OFFLOAD: '1'
                __GLX_VENDOR_LIBRARY_NAME: nvidia
                __VK_LAYER_NV_optimus: NVIDIA_only
            icd: /usr/lib/x86_64-linux-gnu/GL/vulkan/icd.d/nvidia_icd.json
            nvngx_path: /usr/lib/x86_64-linux-gnu/GL/nvidia-535-154-05/extra/nvidia/wine
        amd: &id001
            vendor: amd
            envs:
                DRI_PRIME: '1'
            icd: /usr/lib/x86_64-linux-gnu/GL/vulkan/icd.d/radeon_icd.x86_64.json:/usr/lib/i386-linux-gnu/GL/vulkan/icd.d/radeon_icd.i686.json
    prime:
        integrated: *id001
        discrete: *id002
Kernel:
    Type: Linux
    Version: 6.6.16_1
Disk:
    Total: 7287652352
    Free: 7287472128
RAM:
    MemTotal: 13.6GiB
    MemAvailable: 4.8GiB
Bottles_envs: null

Troubleshooting Logs

No response

Additional context

No response

@LittleAmpton
Copy link
Contributor Author

LittleAmpton commented Jul 13, 2024

I wasn't able to check this until official release, but sadly: this is still not fixed. As I stated in the original post, the issue is not about spaces in the bottle's name per se, but about passing the bottle's directory name (which uses hyphens instead of spaces) instead of the bottle's name (i.e. "Windows-games" instead of "Windows games"). Perhaps my original issue name was misleading, for which I apologize.

LittleAmpton added a commit to LittleAmpton/Bottles that referenced this issue Jul 28, 2024
mirkobrombin added a commit that referenced this issue Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant