Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildsys: exclude README.md from change tracking #996

Merged
merged 1 commit into from
Jul 19, 2020

Conversation

bcressey
Copy link
Contributor

Issue number:
N/A

Description of changes:
This is a follow-up to cd7e66d that also excludes README.md from change tracking for buildsys.

Testing done:
Confirmed that the os package is not rebuilt after changing the mtime of sources/api/README.md, but is rebuilt after changing other sources.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Follow-up to cd7e66d.

We don't use or generate README.md docs during our package builds, so
they don't need to trigger a rebuild.

Signed-off-by: Ben Cressey <[email protected]>
@bcressey bcressey requested review from tjkirch and zmrow July 18, 2020 16:57
Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, neat! I had forgotten about this walk.

@bcressey bcressey removed the request for review from zmrow July 19, 2020 00:58
@bcressey bcressey merged commit d5885a7 into bottlerocket-os:develop Jul 19, 2020
@bcressey bcressey deleted the buildsys-exclude-readme branch July 19, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants