fix CSI drivers and kaniko #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to allow containers to manage tmpfs mounts, since this is expected by the EBS CSI driver, and is a pretty reasonable thing to want to do. We also need to avoid letting containers manage the tmpfs mount for /etc, since this would offer a way to replace the configuration and service files we generate. Signed-off-by: Ben Cressey <[email protected]>
This eliminates the need for a separate preinit program to handle the mount for /etc, and ensures that the filesystem is labeled correctly. Signed-off-by: Ben Cressey <[email protected]>
Now that systemd handles the /etc mount, we no longer need it. Signed-off-by: Ben Cressey <[email protected]>
This allows CNI plugin containers to write the configuration that containerd uses, even if they are not running with a privileged label. Signed-off-by: Ben Cressey <[email protected]>
When starting a container with a command that resides in a different layer, `runc` might see the lower label (`cache_t`) rather than the upper one (`local_t`). Either type is a valid entrypoint into the container domain. Signed-off-by: Ben Cressey <[email protected]>
This was
linked to
issues
Jul 10, 2020
tjkirch
approved these changes
Jul 10, 2020
jamieand
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#975 , #981
Description of changes:
Fix the EBS CSI driver by allowing it to manage tmpfs mounts.
Add a separate label for
/etcand ensure that it's applied so it can't be unmounted or mounted over. Remove the preinit helper since we no longer need it.Allow transitions into the container domains from either
local_t(on the overlay) orcache_t(on the lower directories) since both are valid. This fixes the Kaniko debug image when running it with a command that resides in a VOLUME.Testing done:
E2E tests pass for 1.15, 1.16, 1.17.
Verified that Kaniko can run:
Verified the EBS CSI driver by testing the "block-volume" and "dynamic-provisioning" examples.
Verified the EFS CSI driver by testing the "static_provisioning" example.
Verified that
container_tcannot unmount or mount over/etc.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.