Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storewolf: version argument expects semver value #957

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

samuelkarp
Copy link
Contributor

@samuelkarp samuelkarp commented Jun 24, 2020

Issue number:
None

Description of changes:
The --version argument expects a valid semver value as input. Version numbers without three parts fail with a message saying "Expected dot". This commit updates the documentation to match the behavior of storewolf.

Testing done:
Created a local datastore with a semver version. Attempting to create a datastore with "0.1" as the version failed with the following error:

Invalid version: Expected dot

Usage: ./storewolf
            --data-store-base-path PATH
            [ --version X.Y ]
            [ --log-level trace|debug|info|warn|error ]

        If --version is not given, the version will be pulled from /etc/os-release.
        This is used to set up versioned symlinks in the data store base path.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@samuelkarp samuelkarp requested a review from tjkirch June 24, 2020 23:34
Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a bit of clarification in the commit summary/description that this is a documentation change, not a code change; I was confused because it sounded like we were changing behavior or fixing a bug.

The --version argument expects a valid semver value as input.  Version
numbers without three parts fail with a message saying "Expected dot".
This commit updates the documentation to match the behavior of
storewolf.
@samuelkarp
Copy link
Contributor Author

I'd like to see a bit of clarification in the commit summary/description that this is a documentation change, not a code change; I was confused because it sounded like we were changing behavior or fixing a bug.

Updated, thanks!

Copy link
Member

@jahkeup jahkeup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.2.3-thanks 👏

@samuelkarp samuelkarp merged commit 0738f64 into bottlerocket-os:develop Jun 25, 2020
@samuelkarp samuelkarp deleted the storewolf-semver branch June 25, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants