build: canonicalize to EC2 machine architecture #932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
n/a
Description of changes:
There are places in which architectures may/must be provided vary in which identifier should be provided, like
aarch64
andarm64
. Theamiize.sh
script would get very far before an error is raised about an incorrect choice on the part of the caller. Instead of waiting until theaws ec2 register-image
call, the script will now bail on invalid architectures and also will canonicalize the given value from a supported set (eg:aarch64 -> arm64
).Testing done:
I ran
./amiize.sh
with--arch aarch64
and had a successful image on the other side.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.