Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waves: fix example wave files 'wave' #908

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

etungsten
Copy link
Contributor

@etungsten etungsten commented Apr 16, 2020

Issue number:
N/A

Description of changes:
Updata UpdateWaves expects waves but the example wave files were specifying waves with wave.

/// UpdateWaves is provided for the specific purpose of deserializing
/// update waves from TOML files
#[derive(Debug, Serialize, Deserialize)]
pub struct UpdateWaves {
pub waves: Vec<UpdateWave>,
}

This commit fixes all references of wave to waves.

Testing done:
Updata successfully updates a manifest.toml with default-waves.toml and adds the correct waves.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Updata `UpdateWaves` expects `waves` but the example wave files were
specifying waves with `wave`. This commit fixes all references of `wave`
to `waves`.
@etungsten etungsten requested a review from zmrow April 16, 2020 19:56
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😳 😳 😳

@etungsten etungsten merged commit 06c469e into bottlerocket-os:develop Apr 16, 2020
@etungsten etungsten deleted the many-waves branch April 16, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants