-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin container v0.5.0 migration #903
Admin container v0.5.0 migration #903
Conversation
8c0aadf
to
5f2bf1c
Compare
5f2bf1c
to
840ae08
Compare
Force push above adds missing license information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about needing the revert :(
sources/api/migration/migrations/v0.3.2/migrate-admin-container/Cargo.toml
Outdated
Show resolved
Hide resolved
sources/api/migration/migrations/v0.3.2/migrate-admin-container/Cargo.toml
Outdated
Show resolved
Hide resolved
840ae08
to
72e55db
Compare
Addresses @tjkirch 's comments. Checking why github actions is failing... |
The build check is failing because bottlerocket/tools/rpm2migrations Line 22 in 8af7e0a
In any case, We could also fix this by updating bottlerocket/packages/os/os.spec Lines 215 to 218 in 8af7e0a
|
@etungsten The Dockerfile sets it up so that only the migration rpm is in the packages directory when rpm2migrations is run - see the repobuild section. I think the problem is that what's copying the RPM into /local/migrations, namely the migrationbuild section, is using a "*" after "migration" so that it doesn't have to worry about every single component of the RPM's filename, and that unfortunately captures the debuginfo RPM too. I think we need to make the filename pattern in the I'm not sure why this would have changed... |
Hm... this change in behavior seems... odd. I don't recall seeing this issue when putting together |
72e55db
to
49d2e0c
Compare
Push above removes the direct dependency listing on I'll fix the build issue in a separate PR. |
LGTM, but we shouldn't approve/merge until we know we can build migrations safely again. Perhaps the revert of the WrappedSettings change should also go into the other PR related to fixing the build? |
Adds a new migration to migrate the default admin host-container version from v0.4.0 to v0.5.0.
49d2e0c
to
812b464
Compare
Rebased on develop to get migration build fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌺
Issue number:
Addresses #890
Testing done:
Created a datastore locally using
storewolf
and manually populatedsettings.aws.region
with"us-west-2"
Forward migration:
Backwards migration:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.