Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Pass proxy environment variables through to docker containers. #871

Merged
merged 1 commit into from
Mar 26, 2020
Merged

build: Pass proxy environment variables through to docker containers. #871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tools/docker-go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,19 @@ DOCKER_RUN_ARGS="--network=host"

parse_args "${@}"

# Go accepts both lower and uppercase proxy variables, pass both through.
proxy_env=( )
for i in http_proxy https_proxy no_proxy HTTP_PROXY HTTPS_PROXY NO_PROXY; do
if [ -n "${!i}" ]; then
proxy_env[${#proxy_env[@]}]="--env=$i=${!i}"
fi
smoser marked this conversation as resolved.
Show resolved Hide resolved
done

docker run --rm \
-e GOPRIVATE='*' \
-e GOCACHE='/tmp/.cache' \
-e GOPATH='/tmp/go' \
"${proxy_env[@]}" \
--user "$(id -u):$(id -g)" \
${DOCKER_RUN_ARGS} \
-v "${GO_MOD_CACHE}":/tmp/go/pkg/mod \
Expand Down