Move built rpms to build/packages #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmrow
commented
Mar 18, 2020
| @@ -78,16 +80,20 @@ impl VariantBuilder { | |||
| version_image = version_image, | |||
| version_build = version_build, | |||
| ); | |||
| let tag = format!("buildsys-var-{variant}-{arch}", variant = variant, arch = arch); | |||
| let tag = format!( | |||
There was a problem hiding this comment.
rustfmt changed this formatting, there aren't any actual changes here.
tjkirch
approved these changes
Mar 18, 2020
|
Addresses @tjkirch 's comment |
tjkirch
approved these changes
Mar 18, 2020
bcressey
approved these changes
Mar 19, 2020
|
📦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #781
Description of changes:
buildsysenvironment variable for the/build/packagesdirectorybuildsysto use said directoryDockerfileto take advantage of said directoryMakefile.toml'ssetupandcleantargetsTesting done:
cargo make's output is correctcargo make cleancleans upTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.