QUICKSTART: add easier setup instructions using new eksctl release #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahkeup
reviewed
Mar 12, 2020
| @@ -12,14 +12,89 @@ Once you have a cluster, you can skip to the last step, [Launch!](#launch) | |||
| ## Dependencies | |||
|
|
|||
| EKS has a command-line tool called `eksctl` that makes cluster setup easy. | |||
| First, get [eksctl set up](https://github.com/weaveworks/eksctl). | |||
| Versions of eksctl starting with 0.15.0-rc.2 support Bottlerocket natively. | |||
There was a problem hiding this comment.
nit: the prior line uses the code type face, so let's keep using that.
Suggested change
| Versions of eksctl starting with 0.15.0-rc.2 support Bottlerocket natively. | |
| Versions of `eksctl` starting with `0.15.0-rc.2` support Bottlerocket natively. |
There was a problem hiding this comment.
The code style is there to introduce a new name, but afterward I think it would seem like scare quotes..?
samuelkarp
approved these changes
Mar 12, 2020
etungsten
approved these changes
Mar 12, 2020
tjkirch
force-pushed
the
quickstart-eksctl
branch
from
21e9af6
to
0892c83
Compare
|
This push addresses (most of) @jahkeup's and @samuelkarp's comments. |
jahkeup
approved these changes
Mar 12, 2020
jahkeup
reviewed
Mar 12, 2020
tjkirch
force-pushed
the
quickstart-eksctl
branch
from
0892c83
to
3c66f91
Compare
|
This push fixes the other |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done:
I created clusters with each of these configs and the new instructions, confirming they were able to run pods and connect via SSM. I confirmed that the sample config with SSH was able to connect to the admin container via SSH, and the other was not. The system seemed healthy.