Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up GitHub Actions #837

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Set up GitHub Actions #837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: Build
on:
pull_request:
branches: [develop]
jobs:
build:
runs-on: [self-hosted, linux, x64]
steps:
- uses: actions/checkout@v1
- run: cargo install --version 0.28.0 cargo-make
- run: cargo install --version 0.6.6 cargo-deny --no-default-features
- run: cargo make
Comment on lines +7 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we wanted to extend this to also build arm64, what would that look like? Two separate actions, Build x86_64 and Build arm64?

We could do it here with cargo make clean ; cargo make -e BUILDSYS_ARCH=aarch64 but that would double the time it takes and ideally we'd run them in parallel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

I think we might want to eventually do:

  • Build x86_64
  • Build aarch64
  • Unit tests