Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐈 🚶♂️
One potential downside that's at least worth considering - this may give the appearance that you can request any given key from the apiserver; since now we have "/" and "/settings" you may expect you can get the tree at "/settings/updates". We couldn't do that without a fancier apiserver.
Testing done:
Launched an instance, it joined my cluster and ran a pod, was
running
, seemed OK. I used apiclient and saw that the /settings and /os APIs still work, and saw the new top-level API return everything: