Remove update update-checking boot service and timer #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added during early development to give us a signal about available updates, with a sense that it might have helped with automatic updates. We've since refined our thought, building the update operator for the aws-k8s variant, and starting to plan better solutions for other variants. Also, this causes a failed service (and therefore a "degraded" system) when there are no updates, when in fact having no updates is usually a healthy state.
iliana
approved these changes
Feb 24, 2020
sam-aws
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added during early development to give us a signal about available
updates, with a sense that it might have helped with automatic updates. We've
since refined our thought, building the update operator for the aws-k8s
variant, and starting to plan better solutions for other variants.
Also, this causes a failed service (and therefore a "degraded" system) when
there are no updates, when in fact having no updates is usually a healthy
state.
Issue number:
Fixes #748.
Testing done:
Launched an instance, saw that there was no longer a failed updog service, confirmed that the service/timer didn't appear in list-units output. Ran a pod OK.