Rename workspaces directory to 'sources', package to 'os' #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Feb 22, 2020
etungsten
approved these changes
Feb 22, 2020
iliana
approved these changes
Feb 22, 2020
workspaces was originally a set of Cargo workspaces, but we now build them together because it's much faster to build. This renames the 'workspaces' directory to the clearer 'sources' because it contains our source code. The 'workspaces' package is renamed to 'os' to represent that it contains our top-level / userspace OS components.
tjkirch
force-pushed
the
rename-workspaces
branch
from
1725f11
to
5556330
Compare
|
This push is just a rebase on develop for the two PRs just merged; no change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workspaces was originally a set of Cargo workspaces, but we now build them
together because it's much faster to build. This renames the 'workspaces'
directory to the clearer 'sources' because it contains our source code. The
'workspaces' package is renamed to 'os' to represent that it contains our
top-level / userspace OS components.
Testing done:
Built an image and launched a pod OK (with the fix in #771)