Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'moondog' to 'early-boot-config' #757

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Rename 'moondog' to 'early-boot-config' #757

merged 1 commit into from
Feb 25, 2020

Conversation

zmrow
Copy link
Contributor

@zmrow zmrow commented Feb 20, 2020

Issue number:
N/A

Description of changes:
Changes all references to moondog to early-boot-config

Testing done:

  • All unit tests continue to pass
  • Built and ran an image that joins my cluster, and exercised userdata to enable admin container
bash-5.0# systemctl status early-boot-config
● early-boot-config.service - Bottlerocket userdata configuration system
     Loaded: loaded (/x86_64-bottlerocket-linux-gnu/sys-root/usr/lib/systemd/system/early-boot-config.service; enabled; vendor preset: enabled)
     Active: active (exited) since Thu 2020-02-20 22:15:29 UTC; 14min ago
   Main PID: 3168 (code=exited, status=0/SUCCESS)
      Tasks: 0 (limit: 4483)
     Memory: 0B
     CGroup: /system.slice/early-boot-config.service

Feb 20 22:15:29 ip-192-168-74-192.us-west-2.compute.internal systemd[1]: Starting Bottlerocket userdata configuration system...
Feb 20 22:15:29 ip-192-168-74-192.us-west-2.compute.internal systemd[1]: Started Bottlerocket userdata configuration system.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@zmrow
Copy link
Contributor Author

zmrow commented Feb 20, 2020

Removed unrelated file from the commit (oops)

Copy link
Contributor

@etungsten etungsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 🌔 🐶

@zmrow
Copy link
Contributor Author

zmrow commented Feb 21, 2020

Fixed occurrences of MoondogError 😕

Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming your testing of the /etc file works.

[edit] It does!

@jhaynes jhaynes modified the milestones: Public Preview, v0.3.0 Feb 21, 2020
@tjkirch
Copy link
Contributor

tjkirch commented Feb 24, 2020

This push rebases onto develop, which includes the sources rename. Zac and I did the rebase together and confirmed it results in exactly the same changes.

@zmrow zmrow merged commit cafe8f2 into develop Feb 25, 2020
@zmrow zmrow deleted the rename-moondog branch February 25, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants