buildsys, Makefile: disallow upstream source fallback by default #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliana
reviewed
Feb 14, 2020
jahkeup
reviewed
Feb 14, 2020
buildsys now checks `BUILDSYS_UPSTREAM_SOURCE_FALLBACK` to see whether to use upstream source as fallback during fetch. Makefile updated to set `BUILDSYS_UPSTREAM_SOURCE_FALLBACK` to false
etungsten
force-pushed
the
lookaside-cache-always
branch
from
a6c21e7
to
ebc33f0
Compare
iliana
approved these changes
Feb 15, 2020
jahkeup
approved these changes
Feb 15, 2020
bcressey
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Related to #540
Description of changes:
buildsysnow checks environment variableBUILDSYS_UPSTREAM_SOURCE_FALLBACKto see whether to use upstream source as fallback if fetching from the lookaside cache fails for whatever reason.Makefile updated to set
BUILDSYS_UPSTREAM_SOURCE_FALLBACKtofalse, overridable from the command line by passing-e BUILDSYS_UPSTREAM_SOURCE_FALLBACK=truetocargo make.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.