-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
license-scan: Add Cargo.toml support #719
Conversation
@tjkirch this has an SDK bump, should we merge it into your pending rename branch instead of develop? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems right to me, but it is fairly complex, so I requested a few comments. Would also be good to see some kind of example output in the PR description.
Co-Authored-By: Tom Kirchner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo my utter lack of Rust chops.
f500cd6
to
2cf465e
Compare
Issue #, if available: #469
Description of changes:
license-scan now understands how to get a list of packages from a Cargo.toml and scan it for licenses.
There are now clarify.toml files for
workspaces
andlicense-scan
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.