ci: cd in script's shell instead of "if"s subshell #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implicit subshell of the `if` prevented the `cd` from moving the scripts' working directory (causing issues where builds requires `write-build-meta` output in a specific location: #657).
|
I'll need to kick off another build here with an overridden image containing the fix to verify its fixed here. I expect that the check will fail until then. |
etungsten
approved these changes
Jan 16, 2020
|
Build logs confirm the fix works, in addition to the passing checks.. Will build and push a new backing image with the fix built in before merging. Should see a green checkmark on that merge commit too afterwards. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#657
Description of changes:
The implicit subshell of the
ifprevented thecdfrom moving the scripts' working directory (causing issues where builds requireswrite-build-metaoutput in a specific location: #657).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.