Package acpid to handle shutdown signals #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Oct 19, 2019
| } | ||
| umask(0077); | ||
| - execl("/bin/sh", "/bin/sh", "-c", action, NULL); | ||
| + execl("/sbin/shutdown", "/sbin/shutdown", "-h", "now", "Power button pressed", NULL); |
There was a problem hiding this comment.
Should we run systemctl poweroff instead, so that the action here matches the configuration?
There was a problem hiding this comment.
Oops, brain split. Going to change these both to shutdown -h now.
bcressey
approved these changes
Oct 19, 2019
Signed-off-by: iliana destroyer of worlds <[email protected]>
tjkirch
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: fixes #345
Description of changes:
This adds acpid. The hack to make it not depend on /bin/sh is not something I'm proud of, but it works for what we need it for right now. Because
button/poweris the only event we have listed in a config we should only shutdown on that event.Instance responds to stop/terminate events as well as reboot events correctly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.