Drop AWS K8s 1.23 variants #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the aws-k8s-1.23 and aws-k8s-1.23-nvidia variants following the EKS support policy. The variants go EOL in EKS on October 11 Signed-off-by: Gavin Inglis <[email protected]>
larvacea
approved these changes
Oct 2, 2024
larvacea
approved these changes
Oct 5, 2024
|
Do we also need to remove the k8s-1.23 pkg from the core-kit? |
Yes that work is on my plate, but it's not a requirement for this PR |
bcressey
approved these changes
Oct 7, 2024
|
Also, I see a few more hits for Should these be removed too? |
Those were only used by the k8s-1.23 variants, but good callout, I'll follow up removing those |
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #4083
Description of changes:
Drop the
aws-k8s-1.23andaws-k8s-1.23-nvidiavariants following the EKS support policy. The variants go EOL in EKS on October 11.Testing done:
cargo makesucceeds,cargo make -e BUILDSYS_VARIANT=aws-k8s-1.23andcargo make -e BUILDSYS_VARIANT=aws-k8s-1.23-nvidiafail.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.