-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update permission bits for kubelet-exec-start-conf #4199
base: develop
Are you sure you want to change the base?
Conversation
sources/settings-migrations/v1.23.0/kubernetes-service-config/src/main.rs
Outdated
Show resolved
Hide resolved
Can you verify that the file permissions are not flagged by the CIS Kubernetes report (at either level)? |
Sorry but I'm not quite understand what this means. |
On an image with your changes applied, run this command and check the output:
It needs to continue to say "PASS" for both the 4.1.1 check and the final result. |
It would also be good to check the journal before and after, to confirm that the warnings are no longer logged. |
@Sparksssj can you also verify that the warnings from the related issue are no longer present? |
Yes I confirm that this warning exist in previous version, and disappeared after the change. |
@@ -55,6 +55,7 @@ members = [ | |||
"settings-migrations/v1.23.0/nvidia-container-runtime-settings", | |||
"settings-migrations/v1.23.0/kubelet-device-plugins-metadata", | |||
"settings-migrations/v1.23.0/kubelet-device-plugins-settings", | |||
"settings-migrations/v1.23.0/kubernetes-service-config", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since, we released v1.23.0 yesterday, you will have to aim for 1.24.0 or 1.24.1. You will have to rebase and add the migration files to the appropriate directory.
Issue number:
Closes #4173
Description of changes:
Changed the mode code for configuration-files.kubelet-exec-start-conf, such that it will not generate error message.
Testing done:
Required migration test was done.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.