Migrate to core kit #4060
Merged
Migrate to core kit #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are now provided by the Bottlerocket Core Kit Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
arnaldo2792
force-pushed
the
migrate-to-core-kit
branch
5 times, most recently
from
16b2606
to
c23d72f
Compare
cbgbt
reviewed
Jun 17, 2024
arnaldo2792
force-pushed
the
migrate-to-core-kit
branch
2 times, most recently
from
f6d6e51
to
7a7b5dd
Compare
sam-berning
approved these changes
Jun 17, 2024
| "api/thar-be-updates", | ||
| "api/settings-committer", | ||
| "api/migration/migrator", | ||
| "api/apiclient", |
There was a problem hiding this comment.
nit: this is out of alphabetical order with datastore
| "updater/signpost", | ||
| "updater/update_metadata", | ||
| "updater/updog", | ||
|
|
||
| "constants", |
| @@ -39,3 +39,4 @@ path = "../variants.rs" | |||
| [build-dependencies] | |||
| settings-defaults = { path = "../../packages/settings-defaults" } | |||
| settings-plugins = { path = "../../packages/settings-plugins" } | |||
| settings-migrations = { path = "../../packages/settings-migrations" } | |||
There was a problem hiding this comment.
nit: out of alphabetical order
|
Looks good to me once we have the first core kit release. |
webern
approved these changes
Jun 17, 2024
cbgbt
approved these changes
Jun 18, 2024
They were migrated to the Bottlerocket Core Kit Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
…dencies All the packages the variants depend on are already built in the Bottlerocket Core Kit Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
It was migrated to the Bottlerocket core kit Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Migrations need to stay in-tree along with plugins and defaults, because they are directly related to how settings are configured and how they evolve from one release to the next. Signed-off-by: Ben Cressey <[email protected]>
arnaldo2792
force-pushed
the
migrate-to-core-kit
branch
from
7a7b5dd
to
06958cf
Compare
arnaldo2792
force-pushed
the
migrate-to-core-kit
branch
from
06958cf
to
a9c5844
Compare
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
The SDK is built for two host architectures - x86_64 and aarch64. Each build includes the same two target architectures. However, the libstd.so binary for a given target architecture will not be the same across the two host SDK images, because they are built on different systems and at different times. To reduce file sizes, we prefer dynamically linking to libstd for all Rust binaries, and arrange to install libstd through the libstd-rust package. Prior to the kit migration, we always built the final image with the same host SDK image that was used to build all packages, so the question of which libstd should be shipped never came up. In the kits world, we need the libstd-rust that corresponds to the many Rust binaries that come from the core kit. However, if we prefer dynamic linking, then we also need the libstd-rust that matches the Rust binaries built locally, which may not be the same if the kit was built on a different host architecture. Sidestep this for now by not preferring shared linking for settings plugins, so that they are statically linked to the libstd present in the build environment, and do not require it to be installed in the final image. Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
arnaldo2792
force-pushed
the
migrate-to-core-kit
branch
from
a9c5844
to
5e340b2
Compare
bcressey
approved these changes
Jun 19, 2024
sam-berning
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related to #4048
Description of changes:
This PR migrates the code to use the Bottlerocket core kit.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.