Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update twoliter to v0.2.0 #4008

Merged

Conversation

sumukhballal
Copy link
Contributor

@sumukhballal sumukhballal commented May 30, 2024

Issue number:

Closes #

Description of changes:

Updates twoliter to version v0.2.0 and Twoliter.toml to new specification.

Reference: bottlerocket-os/twoliter#207

Testing done:

  • Build a variant of Bottlerocket (aws-k8s-1.27 & aws-ecs-1).
  • Built an aws-ecs-1 AMI, and made sure Bottlerocket boots.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@sumukhballal sumukhballal requested a review from webern May 30, 2024 14:38
@sumukhballal
Copy link
Contributor Author

Updated Twoliter version to v0.2.0-rc2 and added @webern 's commit

@webern webern changed the title twoliter: update twoliter to v0.2.0 build: update twoliter to v0.2.0 May 30, 2024
@sumukhballal sumukhballal force-pushed the twoliter-v0.2.0-release branch 2 times, most recently from 7915977 to 6a7819f Compare May 31, 2024 00:41
@jpculp
Copy link
Member

jpculp commented May 31, 2024

Using v0.2.0-rc3 I was able to build, boot, and repack aws-k8s-1.28.

@jpculp
Copy link
Member

jpculp commented May 31, 2024

Also built and booted aws-ecs-2.

Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Blocking for the final Twoliter tag only.

Makefile.toml Outdated Show resolved Hide resolved
sumukhballal and others added 4 commits May 31, 2024 15:26
Adds `repack-variant`, `fetch-variant`. `fetch-friendly-variant` and
`fetch-ova`.
Instead of being built as a package, the CA certificate bundle will be
installed via the Bottlerocket SDK or with a local bundle by passing
BUILDSYS_CACERTS_BUNDLE_OVERRIDE.
@sumukhballal
Copy link
Contributor Author

Updated twoliter version to v0.2.0

@sumukhballal sumukhballal marked this pull request as ready for review May 31, 2024 15:44
@sumukhballal sumukhballal merged commit b136a8b into bottlerocket-os:develop May 31, 2024
33 checks passed
@vigh-m vigh-m mentioned this pull request Aug 1, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants