Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages: add neuron kmod for 6.1 kernel #3982

Merged
merged 1 commit into from
May 24, 2024

Conversation

bcressey
Copy link
Contributor

Issue number:
Related: #1995, #1075

Description of changes:
Package the Neuron kernel module for use on Inferentia and Trainium instance types.

Testing done:
Built aws-dev with local changes to include the new package, and a container with neuron-ls installed.

$ docker run -it --rm --device=/dev/neuron0 863599026182.dkr.ecr.us-west-2.amazonaws.com/neuron-tools:latest neuron-ls
Unable to find image '863599026182.dkr.ecr.us-west-2.amazonaws.com/neuron-tools:latest' locallym/neuron-tools:latest neuron-ls
latest: Pulling from neuron-tools
...
Status: Downloaded newer image for 863599026182.dkr.ecr.us-west-2.amazonaws.com/neuron-tools:latest
instance-type: inf1.2xlarge
instance-id: i-02d893416f9f374ce
+--------+--------+--------+---------+
| NEURON | NEURON | NEURON |   PCI   |
| DEVICE | CORES  | MEMORY |   BDF   |
+--------+--------+--------+---------+
| 0      | 4      | 8 GB   | 00:1f.0 |
+--------+--------+--------+---------+

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Comment on lines +1 to +2
[Service]
ExecStartPre=-/usr/bin/depmod
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be necessary after we update to a twoliter release with this change:
bottlerocket-os/twoliter#205

Copy link
Contributor

@monirul monirul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


[[package.metadata.build-package.external-files]]
url = "https://yum.repos.neuron.amazonaws.com/aws-neuronx-dkms-2.16.7.0.noarch.rpm"
sha512 = "8e66feb4051af31321c08b6663a950172da65c4e5b432c0b5609785be34ccb193c0eb50c9aadfeec8b6410ccbe05264a3fb6fc7cb66dc87b172bc5be5c4d92d0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this published in the amazon official sites or we generated it from the downloaded binary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the offical site per the documentation.

@bcressey bcressey merged commit 1982df7 into bottlerocket-os:develop May 24, 2024
33 checks passed
@bcressey bcressey deleted the neuron-kmod branch May 24, 2024 18:01
@vigh-m vigh-m mentioned this pull request Aug 1, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants