logdog: switch to use apiclient cli to get settings #3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
May 6, 2024
webern
reviewed
May 6, 2024
bcressey
reviewed
May 6, 2024
This changes logdog to fetch settings using the apiclient. This creates two breaking changes. First logdog will now include sections such as 'os' in the log. This provides more information in the log. Secondly instead of removing the existence of secret settings their values are replaced with REDACTED. This allows the user to see the setting was there while maintaining the scrubbing of secrets.
|
Updated commit message with description of the breaking change |
bcressey
approved these changes
May 6, 2024
| use datastore::deserialization::from_map; | ||
| use datastore::serialization::to_pairs; | ||
| use glob::{glob, Pattern}; | ||
| use glob::glob; |
There was a problem hiding this comment.
We can drop the glob dependency it looks like?
There was a problem hiding this comment.
I wish but it is used in another method i used udeps to validate
There was a problem hiding this comment.
its used by handle_glob_request
webern
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: 3784
Closes #3784
Description of changes:
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.