-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static-pods: remove conditional compilation #3891
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| [package] | ||
| name = "static-pods" | ||
| version = "0.1.0" | ||
| edition = "2021" | ||
| publish = false | ||
| build = "../build.rs" | ||
|
|
||
| [package.metadata.build-package] | ||
| source-groups = [ | ||
| "api/static-pods" | ||
| ] | ||
|
|
||
| [lib] | ||
| path = "../packages.rs" | ||
|
|
||
jmt-lab marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| [build-dependencies] | ||
| glibc = { path = "../glibc" } | ||
|
|
||
| [dependencies] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| [required-extensions] | ||
| kubernetes = "v1" | ||
| std = { version = "v1", helpers = ["if_not_null"] } | ||
| +++ | ||
| {{#if_not_null settings.kubernetes.static-pods}} | ||
| {{#each settings.kubernetes.static-pods}} | ||
| ["{{@key}}"] | ||
| {{#if_not_null this.enabled}} | ||
| enabled = {{this.enabled}} | ||
| {{/if_not_null}} | ||
| {{#if_not_null this.manifest}} | ||
| manifest = "{{{this.manifest}}}" | ||
| {{/if_not_null}} | ||
| {{/each}} | ||
| {{/if_not_null}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| %global _cross_first_party 1 | ||
| %undefine _debugsource_packages | ||
|
|
||
| Name: %{_cross_os}static-pods | ||
| Version: 0.0 | ||
| Release: 0%{?dist} | ||
| Summary: Manages user-defined K*S static pods | ||
| License: Apache-2.0 OR MIT | ||
| URL: https://github.com/bottlerocket-os/bottlerocket | ||
|
|
||
| Source0: static-pods-toml | ||
|
|
||
| BuildRequires: %{_cross_os}glibc-devel | ||
|
|
||
| %description | ||
| %{summary}. | ||
|
|
||
| %prep | ||
| %setup -T -c | ||
| %cargo_prep | ||
|
|
||
| %build | ||
| mkdir bin | ||
|
|
||
| echo "** Compile static-pods agent" | ||
| %cargo_build --manifest-path %{_builddir}/sources/Cargo.toml \ | ||
| -p static-pods | ||
|
|
||
| %install | ||
| install -d %{buildroot}%{_cross_bindir} | ||
| install -p -m 0755 ${HOME}/.cache/%{__cargo_target}/release/static-pods %{buildroot}%{_cross_bindir} | ||
|
|
||
| install -d %{buildroot}%{_cross_templatedir} | ||
| install -p -m 0644 %{S:0} %{buildroot}%{_cross_templatedir} | ||
|
|
||
| %files | ||
| %{_cross_bindir}/static-pods | ||
| %{_cross_templatedir}/static-pods-toml |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
sources/api/migration/migrations/v1.20.0/static-pods-add-prefix-v0-1-0/Cargo.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| [package] | ||
| name = "static-pods-add-prefix-v0-1-0" | ||
| version = "0.1.0" | ||
| authors = ["Jarrett Tierney <[email protected]>"] | ||
| license = "Apache-2.0 OR MIT" | ||
| edition = "2021" | ||
| publish = false | ||
| exclude = ["README.md"] | ||
|
|
||
| [dependencies] | ||
| migration-helpers = { path = "../../../migration-helpers", version = "0.1.0" } |
16 changes: 16 additions & 0 deletions
16
sources/api/migration/migrations/v1.20.0/static-pods-add-prefix-v0-1-0/src/main.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| use migration_helpers::common_migrations::AddPrefixesMigration; | ||
| use migration_helpers::{migrate, Result}; | ||
| use std::process; | ||
|
|
||
| fn run() -> Result<()> { | ||
| migrate(AddPrefixesMigration(vec![ | ||
| "configuration-files.static-pods-toml", | ||
| ])) | ||
| } | ||
|
|
||
| fn main() { | ||
| if let Err(e) = run() { | ||
| eprintln!("{}", e); | ||
| process::exit(1); | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
sources/api/migration/migrations/v1.20.0/static-pods-services-cfg-v0-1-0/Cargo.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| [package] | ||
| name = "static-pods-services-cfg-v0-1-0" | ||
| version = "0.1.0" | ||
| authors = ["Jarrett Tierney <[email protected]>"] | ||
| license = "Apache-2.0 OR MIT" | ||
| edition = "2021" | ||
| publish = false | ||
| exclude = ["README.md"] | ||
|
|
||
| [dependencies] | ||
| migration-helpers = { path = "../../../migration-helpers", version = "0.1.0" } |
18 changes: 18 additions & 0 deletions
18
sources/api/migration/migrations/v1.20.0/static-pods-services-cfg-v0-1-0/src/main.rs
jmt-lab marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| use migration_helpers::common_migrations::{ListReplacement, ReplaceListsMigration}; | ||
| use migration_helpers::{migrate, Result}; | ||
| use std::process; | ||
|
|
||
| fn run() -> Result<()> { | ||
| migrate(ReplaceListsMigration(vec![ListReplacement { | ||
| setting: "services.static-pods.configuration-files", | ||
| old_vals: &[], | ||
| new_vals: &["static-pods-toml"], | ||
| }])) | ||
| } | ||
|
|
||
| fn main() { | ||
| if let Err(e) = run() { | ||
| eprintln!("{}", e); | ||
| process::exit(1); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,3 @@ | ||
| use bottlerocket_variant::Variant; | ||
|
|
||
| fn main() { | ||
| let variant = Variant::from_env().unwrap(); | ||
| variant.emit_cfgs(); | ||
| generate_readme::from_file("src/static_pods.rs").unwrap(); | ||
| generate_readme::from_main().unwrap(); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
static-podsno longer depends on the API, it should move out from undersources/apiso that this package can watch the specific directory (sources/static-pods) and so that changes don't also trigger a rebuild ofos.