Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document package build tools for go dependencies #3882

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

larvacea
Copy link
Member

@larvacea larvacea commented Apr 9, 2024

We have tooling to handle go module dependencies when building a Bottlerocket package. The README.md in packages/ should describe how to use this when building a go package.

Description of changes:

Add documentation for bundle-modules to the README.

Testing done:

I read it and previewed the markdown. The examples are taken from the work I did for soci-snapshotter, which builds.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

We have tooling to handle go module dependencies when building a
Bottlerocket package. The README.md in packages/ should describe how to
use this when building a go package.
@larvacea larvacea self-assigned this Apr 10, 2024
packages/README.md Outdated Show resolved Hide resolved
packages/README.md Outdated Show resolved Hide resolved
packages/README.md Outdated Show resolved Hide resolved
packages/README.md Outdated Show resolved Hide resolved
packages/README.md Outdated Show resolved Hide resolved
packages/README.md Outdated Show resolved Hide resolved
@larvacea
Copy link
Member Author

I have incorporated @yeazelm's suggestions. Thanks!

Copy link
Contributor

@yeazelm yeazelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@larvacea larvacea merged commit 2824566 into bottlerocket-os:develop Apr 15, 2024
@larvacea larvacea deleted the document-go-mod branch April 15, 2024 17:52
ginglis13 pushed a commit to ginglis13/bottlerocket that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants