Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce variant matrix size in CI #3863

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

bcressey
Copy link
Contributor

Issue number:
N/A

Description of changes:
Adjust the list-variants action to pick the *-nvidia flavors of variants when they exist, since from a CI perspective they provide similar but greater coverage.

Remove the global upstream source fallback for nvidia variants since this should be covered by the package-level exception. This fixes a current issue where if a package is not present in the lookaside cache, the nvidia builds can succeed while all others fail.

Testing done:
Ran the equivalent script locally:

❯ ls -d */ | cut -d'/' -f 1 | grep -vE '^(shared|target)$' | sort | awk '$0 != x "-nvidia" && NR>1 {print x} {x=$0} END {print}' | jq -R -s 'split("\n")[:-1]
'
[
  "aws-dev",
  "aws-ecs-1-nvidia",
  "aws-ecs-2-nvidia",
  "aws-k8s-1.23-nvidia",
  "aws-k8s-1.24-nvidia",
  "aws-k8s-1.25-nvidia",
  "aws-k8s-1.26-nvidia",
  "aws-k8s-1.27-nvidia",
  "aws-k8s-1.28-nvidia",
  "aws-k8s-1.29-nvidia",
  "aws-k8s-1.30-nvidia",
  "metal-dev",
  "metal-k8s-1.25",
  "metal-k8s-1.26",
  "metal-k8s-1.27",
  "metal-k8s-1.28",
  "metal-k8s-1.29",
  "vmware-dev",
  "vmware-k8s-1.25",
  "vmware-k8s-1.26",
  "vmware-k8s-1.27",
  "vmware-k8s-1.28",
  "vmware-k8s-1.29",
  "vmware-k8s-1.30"
]

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

The "aws-*-nvidia" variants have the same settings model as their
unflavored counterparts, and build a superset of the packages. For CI
purposes, they provide enough coverage that there's no need to build
the non-nvidia ones.

Signed-off-by: Ben Cressey <[email protected]>
The "kmod-*-nvidia" packages have `force-upstream = true` set in the
build metadata. All of the other packages are expected to be in the
lookaside cache.

Signed-off-by: Ben Cressey <[email protected]>
@bcressey bcressey merged commit c5c4767 into bottlerocket-os:develop Apr 4, 2024
35 checks passed
@bcressey bcressey deleted the reduce-variant-checks branch April 4, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants