Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host-containers: render config file with if_not_null #3842

Merged

Conversation

sam-berning
Copy link
Contributor

Issue number:

N/A

Description of changes:

#3777 would skip rendering enabled or superpowered when they were set to false because the if handlebars helper checks for any falsy value. This instead checks that settings values are not null with the new if_not_null helper before rendering them, allowing false values to be rendered correctly.

Testing done:

Spun up an aws-dev instance and modified settings, verifying that the config file was updated correctly.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@sam-berning sam-berning merged commit 7da0aba into bottlerocket-os:develop Mar 21, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants