Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prairiedog: if the variant doesn't support boot settings be okay with… #3836

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jmt-lab
Copy link
Contributor

@jmt-lab jmt-lab commented Mar 20, 2024

… None

Description of changes:

  • Made the reading method to return None should the file not exist.

Testing done:

  • Launched aws-ecs-1 and ensured it properly joined the ecs cluster

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear on why we are hitting these cases where a template file isn't rendered yet. I will need help creating a mental model of what is happening during template rendering (i.e. order of ops).

@jmt-lab jmt-lab requested a review from bcressey March 22, 2024 19:41
@arnaldo2792
Copy link
Contributor

@webern, the case that I saw was that in aws-ecs-1, the bootconfig.toml defaults aren't used. With the ongoing work to use configuration files instead of API calls, the generation of the configuration for prairiedog was moved to the API. Since the service that creates the configuration file is added by the bootconfig.toml defaults, the file is never rendered for aws-ecs-1.

@jmt-lab jmt-lab merged commit cf8f2b7 into bottlerocket-os:develop Mar 26, 2024
50 checks passed
@jmt-lab jmt-lab deleted the jmt/prairiedog/fix-ecs-1 branch March 26, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants