-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go and rust dependencies #3830
Update go and rust dependencies #3830
Conversation
8ccaad6
to
b27e4b7
Compare
hyper proxy fix, this should hopefully get us going |
636143d
to
393c0fa
Compare
393c0fa
to
7a8ed39
Compare
Unit tests passed, good to go |
15c3ea0
to
f3cba92
Compare
1b3d953
to
2e5debf
Compare
Test Report for migration testing and k8s conformance:
|
@@ -59,7 +60,7 @@ impl Terminal { | |||
|
|||
// Get the current settings of the user's terminal so we can restore them later. | |||
let current_termios = | |||
tcgetattr(STDOUT_FILENO).context(error::TermAttrSnafu { op: "get" })?; | |||
tcgetattr(io::stdout()).context(error::TermAttrSnafu { op: "get" })?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: test enter-admin-container
async fn sdk_imds_client() -> Result<imds::Client> { | ||
fn sdk_imds_client() -> imds::Client { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah, wait a minute. The IMDS client went from async to blocking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yerp
@@ -45,7 +46,7 @@ pub(crate) fn fetch_proxy_env() -> (Option<String>, Option<String>) { | |||
pub(crate) fn setup_http_client( | |||
https_proxy: String, | |||
no_proxy: Option<String>, | |||
) -> Result<impl Into<aws_smithy_client::http_connector::HttpConnector>> { | |||
) -> Result<ProxyConnector<HttpsConnector<HttpConnector>>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: test proxy
sources/deny.toml
Outdated
{ name = "base64", version = "=0.13" }, | ||
# AWS SDK for rust uses an older version of fastrand | ||
{ name = "fastrand", version = "=1.9" }, | ||
# sdk still uses 0.7.5 but everything in this repo now uses 0.8.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"sdk" is ambiguous. Use "settings sdk" everywhere to be more clear.
# sdk still uses 0.7.5 but everything in this repo now uses 0.8.2 | |
# settings sdk still uses 0.7.5 but everything in this repo now uses 0.8.2 |
2e5debf
to
02159dd
Compare
Updated per matt's comment. Proxy tested and passes
|
02159dd
to
3a0d6d3
Compare
Description of changes:
Testing done:
testsys run will be kicked off in the morning
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.