fix: provide runtime cgroups to kubelet

[ginglis13]

Issue number:

Closes #3776

Description of changes:

Pass the cgroup where containerd is running to kubelet to enable container resource and performance monitoring via tools like cadvisor.

Testing done:

Tested on aws-k8s-1.23-aarch64 and aws-k8s-1.29-aarch64:

$ kubectl get --raw "/api/v1/nodes/${NODE_NAME}/proxy/stats/summary" | jq -r '.node.systemContainers[] | .name'
pods
kubelet
runtime

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

[Donnerdiebel]

Hi all!

Any chances that this will get merged in the near future?

We just ran into this problem and deploying additional cAdvisors to be able to collect runtime metrics when using bottlerocket amis on EKS is not exactly outr preferred solution.
Anyways, thanks for taking a look into this and creating the fix.

All the best!

[ginglis13]

Hi all!

Any chances that this will get merged in the near future?

We just ran into this problem and deploying additional cAdvisors to be able to collect runtime metrics when using bottlerocket amis on EKS is not exactly outr preferred solution. Anyways, thanks for taking a look into this and creating the fix.

All the best!

Hey @Donnerdiebel , thanks for the bump. I've got some additional testing to do for this change and haven't gotten around to it... I'll try to have an update by the end of the week 😄

[gthao313]

The change and test looks good to me.
Just have a nit for future commit message. It would be recommended to give info like what package you have changes on.
For example, fix: provide runtime cgroups to kubelet can be kubernetes: provide runtime cgroups to kubelet. : )

[ginglis13]

^ reword commit message

[dhumphries-sainsburys]

Do we know when this is going to be released to a tag as doesn't seem to be there yet?

[ginglis13]

Hi @dhumphries-sainsburys, you are correct that this fix has not yet made it into an official release of Bottlerocket. It will be included in the next release, which the team is still working to plan and prioritize.

[saikumarch7548]

when is the next release planned @ginglis13

[ginglis13]

Hi @saikumarch7548, this change has been included in the latest release of Bottlerocket, v1.19.5: https://github.com/bottlerocket-os/bottlerocket/releases/tag/v1.19.5

[saikumarch7548]

@ginglis13 , Thank you , we have tested it in our product and it works