Fix how configurations files are created for the nvidia-container-toolkit #3790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N / A
Description of changes:
In 911775f, we changed how the configuration files for the nvidia-container-toolkit were created, and used
%post
install scripts to create hard links to the correspondent configuration per variant. However, the hard links weren't created since the lua scripts use relative paths instead of absolute paths and the builds didn't fail since%post
install scripts fail silently.With this commit, instead of creating hard links with
%post
install scripts, the configuration files for the nvidia-container-toolkit are copied over with tmpfiles.d configuration files.Testing done:
NVIDIA_VISIBLE_DEVICES=all
:%post
install script was used:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.