certdog: change certdog to use a generated certdog.toml file #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmt-lab
force-pushed
the
jmt/ootb/certdog-config-file
branch
from
121d793
to
ee8a24b
Compare
bcressey
reviewed
Jan 9, 2024
arnaldo2792
reviewed
Jan 10, 2024
jmt-lab
force-pushed
the
jmt/ootb/certdog-config-file
branch
5 times, most recently
from
258e5bb
to
4f418f9
Compare
bcressey
reviewed
Jan 25, 2024
sources/api/migration/migrations/v1.18.1/certdog-v0-1-1/Cargo.toml
Outdated
Show resolved
Hide resolved
sources/api/migration/migrations/v1.18.1/certdog-v0-1-1/src/main.rs
Outdated
Show resolved
Hide resolved
webern
reviewed
Jan 26, 2024
sources/api/migration/migrations/v1.18.1/certdog-v0-1-1/src/main.rs
Outdated
Show resolved
Hide resolved
jmt-lab
force-pushed
the
jmt/ootb/certdog-config-file
branch
from
03fbb5c
to
ebf1a29
Compare
|
Updated per comments |
jmt-lab
force-pushed
the
jmt/ootb/certdog-config-file
branch
from
ebf1a29
to
8dd9b5c
Compare
|
Fix build issue |
Still has unused imports. |
jmt-lab
force-pushed
the
jmt/ootb/certdog-config-file
branch
from
8dd9b5c
to
ebd9581
Compare
|
Removing unused imports |
jmt-lab
force-pushed
the
jmt/ootb/certdog-config-file
branch
from
ebd9581
to
d553ba9
Compare
|
Rebased on latest |
webern
approved these changes
Feb 7, 2024
|
Let's merge this first #3768 then rebase your PR to align on 1.19.2 |
jmt-lab
force-pushed
the
jmt/ootb/certdog-config-file
branch
3 times, most recently
from
9a9f2f5
to
b85b0a2
Compare
webern
reviewed
Feb 12, 2024
sources/api/migration/migrations/v1.19.2/certdog-service-cfg-v0-1-0/src/main.rs
Show resolved
Hide resolved
bcressey
reviewed
Feb 12, 2024
sources/api/migration/migrations/v1.19.2/certdog-config-file-v0-1-0/src/main.rs
Outdated
Show resolved
Hide resolved
jmt-lab
force-pushed
the
jmt/ootb/certdog-config-file
branch
from
b85b0a2
to
b0df678
Compare
|
Rebased off latest |
bcressey
approved these changes
Feb 13, 2024
webern
approved these changes
Feb 13, 2024
arnaldo2792
reviewed
Feb 13, 2024
jmt-lab
force-pushed
the
jmt/ootb/certdog-config-file
branch
from
b0df678
to
140cd8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #3623
Closes #3623
Description of changes:
Changed certdog binary to accept an argument -c instead of -s that defaults to the location /etc/certdog.toml. This toml file will be generated by schnauzer from settings.pki. Certdog now will read the custom certificates from this generated template instead of calling back to the settings api.
Testing done:
Tested via ecs using the aws-ecs-2 variant and verified that the file is generated correctly and certdog runs with no errors
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.